Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to step 1 when there is error for edit drawers #457

Merged
merged 2 commits into from
Feb 27, 2022

Conversation

willyyhuang
Copy link
Contributor

Fix a bug where edit drawer does not return to step 1 on submit

@codeclimate
Copy link

codeclimate bot commented Feb 27, 2022

Code Climate has analyzed commit 3b56d72 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 91.7% (0.1% change).

View more on Code Climate.

@willyyhuang willyyhuang added bug Something isn't working front end labels Feb 27, 2022
@willyyhuang willyyhuang added this to the Sprint #8 milestone Feb 27, 2022
Copy link
Collaborator

@pascwhale pascwhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really improves the UX of the application. The changes work perfectly!

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@willyyhuang willyyhuang merged commit 0d717e9 into main Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants