-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
English/French translations + edit drawer error handling #441
Conversation
Code Climate has analyzed commit bef89a0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 89.9% (90% is the threshold). This pull request will bring the total coverage in the repository to 91.6% (0.3% change). View more on Code Climate. |
Diff-coverage is 89.9% and total coverage increased by 0.3%, the reason why diff-coverage can not be achieved to 90% is because there are conditions where we can't test in unit tests now, such as autocomplete fields and |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! You really were thorough with the translations; it seems that everything is covered.
The implementation of the translation framework is very clean as well.
We should discuss about the presence of the language selection drop down in the front page.
Closes #385 , #423
Added react-i18next to handle english/french translations
Edit drawer should not close on failure as well now.
Usage of react-i18next is
useTranslation
hook (since we are using functional components, hooks work the best)