Loading button #427
Merged
Loading button #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willyyhuang
added
task
willyyhuang
requested review from
m-triassi,
luigibesani,
pascwhale,
IanjhPhillips and
AnnieTran13
|
Code Climate has analyzed commit 1bf9bbf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 91.3% (90% is the threshold). This pull request will bring the total coverage in the repository to 91.2% (0.0% change). View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed! |
luigibesani
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
As hinted in the PR description, the character import's request is long enough to trigger the loading animation on the final button. Looks great. Good work @willyyhuang!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #407
Added loading button component which shows circular motion when making requests
This also fixes the user name being too long on resized window
Notable place to test:
character import