Campaign Index and Create/Edit form #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton based on type
luigibesani
added
front end
task
willyyhuang
reviewed
Feb 20, 2022
| characters, | ||
| }: CampaignCreateFormPropType) => { | ||
| const CAMPAIGN_CREATE_FORM_INITIAL_VALUE: CampaignFormDataType = { | ||
| title: '', |
| useForm<CampaignFormDataType>(CAMPAIGN_INITIAL_VALUE) | ||
|
|
||
| return ( | ||
| <> |
There was a problem hiding this comment.
dont need this empty tag
| </Grid> | ||
| <Grid container spacing={4}> | ||
| <Grid item xs={4}> | ||
| <Button onClick={() => onCloseDrawer && onCloseDrawer()} fullWidth> |
There was a problem hiding this comment.
dont think this covers when you cancel from create view
|
|
||
| const Campaign = ({campaigns, characters, adventures}: CampaignPropType) => { | ||
| const [isEditDrawerOpen, setIsEditDrawerOpen] = useState<boolean>(false) |
There was a problem hiding this comment.
please use useEditDrawer
…input properly
willyyhuang
reviewed
Feb 20, 2022
resources/js/Utils/formatter.ts
Outdated
| @@ -1,2 +1,5 @@ | |||
| export const itemFormatter = (items: any[]) => | |||
| items.map((item: any) => item.name).join(', ') | |||
|
|
|||
| export const characterNameFormatter = (characters: any[]) => | |||
| characters.map((character: any) => character.name).join(', ') | |||
There was a problem hiding this comment.
if these are the same as itemFormatter, I think you can write a more generic function to accommodate both
There was a problem hiding this comment.
You're right, Ill join these two and update it in both the Campaign table and Item table
…ssion-tome into 384-campaign-index
willyyhuang
reviewed
Feb 21, 2022
| @@ -76,7 +76,7 @@ const EntryTable = ({ | |||
| { | |||
| property: 'items', | |||
| title: 'Magic Items', | |||
| render: (value: any) => itemFormatter(value), | |||
| render: (value: any) => objectArrayFormatter(value), | |||
willyyhuang
approved these changes
Feb 21, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384
Closes #386
Description
Changes made