Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data table search bar not filtering correctly #277

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

willyyhuang
Copy link
Contributor

@willyyhuang willyyhuang commented Jan 12, 2022

Closes #270

This branch fixes filter in DataTable

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jan 12, 2022

Code Climate has analyzed commit 56e18d3 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 88.3% (0.0% change).

View more on Code Climate.

@willyyhuang willyyhuang added bug Something isn't working front end labels Jan 12, 2022
@willyyhuang willyyhuang added this to the Sprint #6 milestone Jan 12, 2022
Copy link
Contributor

@m-triassi m-triassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is small enough that i'll just merge this myself, it makes sense to me, good fix!

@m-triassi m-triassi merged commit 3acdc98 into main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Character Search Bar searches on incorrect fields
2 participants