Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement action to create dm rating upon entry store/update #257

Merged
merged 10 commits into from
Jan 12, 2022

Conversation

JasonGadoury
Copy link
Contributor

Description

Closes #206

Adds an action that creates a DM rating when rating data is passed in EntryStoreRequest/ EntryUpdateRequest.

How to test

Store:

  1. Create an entry that includes a valid rating_data array within the EntryStoreRequest
  2. Query for a Rating that matches the created entry's id
  3. Check if decimal value of Rating's 'categories' field matches the binary value corresponding to the rating categories specified as true in request

Store:

  1. Create an entry
  2. Make an update to the entry that includes a valid rating_data array in the EntryUpdateRequest
  3. Query for a Rating that matches the created entry's id
  4. Check if decimal value of Rating's 'categories' field matches the binary value corresponding to the rating categories specified as true in request

Copy link
Contributor

@m-triassi m-triassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's a little suggestion for your action

app/Actions/CreateAndAttachRating.php Outdated Show resolved Hide resolved
@JasonGadoury JasonGadoury changed the title 206 attach gm rating to entry Implement action to create dm rating upon entry store/update Jan 12, 2022
@JasonGadoury JasonGadoury marked this pull request as ready for review January 12, 2022 04:21
Copy link
Contributor

@m-triassi m-triassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, good to see this one finally complete 👀

app/Actions/CreateAndAttachRating.php Outdated Show resolved Hide resolved
app/Http/Controllers/EntryController.php Outdated Show resolved Hide resolved
app/Http/Controllers/EntryController.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
7.5% 7.5% Duplication

@JasonGadoury JasonGadoury merged commit 744aa47 into main Jan 12, 2022
@JasonGadoury JasonGadoury self-assigned this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach ratings to GMs upon entry creation
2 participants