Skip to content

Commit

Permalink
Use latest TAS client (microsoft#2131)
Browse files Browse the repository at this point in the history
* Upgrade tas client version

* Make awareness survey no longer language dependent
  • Loading branch information
bwateratmsft authored and Dmarch28 committed Mar 4, 2021
1 parent 483170a commit 97cb977
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2649,7 +2649,7 @@
"vscode-azureextensionui": "^0.33.6",
"vscode-languageclient": "^6.1.3",
"vscode-nls": "^4.1.2",
"vscode-tas-client": "^0.0.864",
"vscode-tas-client": "^0.1.4",
"xml2js": "^0.4.23"
}
}
4 changes: 1 addition & 3 deletions src/telemetry/surveys/awareness.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
* Licensed under the MIT License. See License.md in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import * as vscode from 'vscode';
import { ext } from '../../extensionVariables';
import { localize } from '../../localize';
import { Survey } from './SurveyManager';
Expand All @@ -24,7 +23,6 @@ async function isEligible(): Promise<boolean> {
const overallActivity = ext.activityMeasurementService.getActivityMeasurement('overall');
const noEditActivity = ext.activityMeasurementService.getActivityMeasurement('overallnoedit');

return (vscode.env.language === 'en' || vscode.env.language.startsWith('en-')) &&
overallActivity.totalSessions >= minimumOverallSessions &&
return overallActivity.totalSessions >= minimumOverallSessions &&
noEditActivity.totalSessions <= maximumNotEditOnlySessions;
}

0 comments on commit 97cb977

Please sign in to comment.