Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some potentially confusing naming #269

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Conversation

AlexHill
Copy link
Contributor

@AlexHill AlexHill commented Mar 6, 2015

I feel that the line NameError: name 'names' is not defined could be a bit confusing. Too many names! I think it's clearer if the variable we're using has nothing to do with the string "name". I've also made the incorrect variable name a typo of the correct one, which ties in with the explanatory text that follows.

On the other hand, the example now differs from those before and after it, so I totally understand if you'd rather not make this change.

@keikoro
Copy link

keikoro commented Mar 6, 2015

One solution would be to change the other examples as well. (;

@aniav aniav closed this Mar 27, 2015
@aniav
Copy link
Member

aniav commented Mar 27, 2015

Ah damn, not this pull request.

@aniav aniav reopened this Mar 27, 2015
@aniav
Copy link
Member

aniav commented Mar 27, 2015

I am merging this and I will change the example in other languages. Thank you! ⚡

aniav added a commit that referenced this pull request Mar 27, 2015
Change some potentially confusing naming
@aniav aniav merged commit 4985ff4 into DjangoGirls:master Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants