Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pip-tools to help maintain packages [#618] #624

Merged
merged 3 commits into from
Aug 10, 2021

Conversation

marksweb
Copy link
Collaborator

This follows on from #620 - starting from an upto date main branch & keeping these changes as simple as they should be.

There is a bug fix release for django which would be worth introducing with this - 2.0.13

@marksweb
Copy link
Collaborator Author

@carltongibson This is as simple as the change should have been...

Copy link
Contributor

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so in general I think we can adopt this... but at the speed @amakarudze is happy with, because it's a new tool that she has to learn.

@marksweb — I think pip-tools is perhaps not standard, so could you add paragraph to the README about it, with a link to the docs, and the core Adjust .in, run pip-compile flow, so that future maintainers have a guide?

requirements.in Outdated
Comment on lines 19 to 20
# Django suit breaks with Django 2.2
django==2.0.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the key one. Getting back onto a supported Django would be a good step.

But yes, we can bump Django 2.0 to latest. 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some talk of people running django-suit from forks which have support for django 3 so there's a potential way to get django updated that way while replacing the functionality django-suit brings.

darklow/django-suit#475 (comment)

@marksweb
Copy link
Collaborator Author

OK, so in general I think we can adopt this... but at the speed @amakarudze is happy with, because it's a new tool that she has to learn.

@marksweb — I think pip-tools is perhaps not standard, so could you add paragraph to the README about it, with a link to the docs, and the core Adjust .in, run pip-compile flow, so that future maintainers have a guide?

Yeah completely agree, but it's key to get this involved while there isn't much movement in the requirements, if the upcoming goals are to move packages on. And I'm happy to support @amakarudze with all this.

I certainly can. I've just done very similar for django-cms where I added this to the docs requirements. 👍

@carltongibson
Copy link
Contributor

Thanks @marksweb — your help here is very much appreciated.

@marksweb
Copy link
Collaborator Author

Useful info added to the readme 👍

Copy link
Contributor

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice description. Thanks @marksweb 🏅

@marksweb
Copy link
Collaborator Author

@amakarudze So this is ready to merge when you are.

As it stands, merging this won't change anything other than installing pip-tools and a patch release for a django regression.

Once you've merged this, run pip-compile -U to get a feel for what this will do. You'll see all the dependencies update, things like boto.

Most upgrades, when there are as many packages pinned as we have here, will be safe, patch releases and minor version changes.

If you've got any questions about anything, let me know.

@amakarudze
Copy link
Contributor

amakarudze commented Aug 10, 2021

Sorry @marksweb, I thought I had merged this but have been experiencing some network issues today and was getting many errors on GitHub. Let me merge now and then do deployment tomorrow.

@amakarudze amakarudze merged commit 70343b0 into DjangoGirls:main Aug 10, 2021
@amakarudze amakarudze linked an issue Aug 10, 2021 that may be closed by this pull request
@marksweb marksweb deleted the feature/618/piptools branch August 10, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pip-tools to help maintain dependencies
3 participants