Skip to content

Commit

Permalink
Treat V8 platform symbols same as base
Browse files Browse the repository at this point in the history
This exports V8 platform symbols in the Node shared library build.
  • Loading branch information
sparist committed Sep 13, 2023
1 parent 4fd8cd6 commit d2da1b9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1339,10 +1339,7 @@
'<(V8_ROOT)/src/libplatform/worker-thread.h',
],
'conditions': [
['component=="shared_library"', {
'direct_dependent_settings': {
'defines': ['USING_V8_PLATFORM_SHARED'],
},
['is_component_build', {
'defines': ['BUILDING_V8_PLATFORM_SHARED'],
}],
['v8_use_perfetto==1', {
Expand Down

0 comments on commit d2da1b9

Please sign in to comment.