Skip to content

Commit

Permalink
Fix Unrecognized command line option -msign-return-address=all
Browse files Browse the repository at this point in the history
Ticket: nodejs#42888
  • Loading branch information
sparist committed Dec 1, 2022
1 parent 9ca57fa commit c30eba9
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions configure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1245,9 +1245,10 @@ def configure_node(o):

o['variables']['want_separate_host_toolset'] = int(cross_compiling)

# Enable branch protection for arm64
if target_arch == 'arm64':
o['cflags']+=['-msign-return-address=all']
# See: https://github.com/nodejs/node/issues/42888
# # Enable branch protection for arm64
# if target_arch == 'arm64':
# o['cflags']+=['-msign-return-address=all']

if options.node_snapshot_main is not None:
if options.shared:
Expand Down

0 comments on commit c30eba9

Please sign in to comment.