SOV-3117: reward claiming #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creed-victor
added
enhancement
🦋 Changeset detectedLatest commit: 9e0c9e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for sovryn-storybook canceled.
|
✅ Deploy Preview for sovryn-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
creed-victor
force-pushed
the
feat/SOV-2799-d-2-update-fee-share-claiming
branch
from
ca1f2d9 to
687cd09
Compare
creed-victor
force-pushed
the
feat/SOV-2799-d-2-update-fee-share-claiming
branch
from
4a5855d to
9ea3b0f
Compare
creed-victor
removed
the
do-not-merge
tiltom
requested changes
Sep 21, 2023
There was a problem hiding this comment.
@creed-victor I tried the Withdraw all functionality but SOV and ZUSD fees were not withdrawn, even though the tx was successful. Can you look into it? My testing address is 0xaaa5a190accbc50f4f9c130b5876521e4d5f9d6c if needed.
apps/frontend/src/app/5_pages/RewardsPage/components/Staking/Staking.tsx
Outdated
Show resolved
Hide resolved
...rc/app/5_pages/RewardsPage/components/Staking/components/WithdrawAllFees/WithdrawAllFees.tsx
Outdated
Show resolved
Hide resolved
This is how smart contract function works and it's expected. If user has a lot of tokens and checkpoints, they will have to send multiple transactions until all tokens/checkpoints are withdrawn. |
tiltom
approved these changes
Sep 22, 2023
soulBit
approved these changes
Sep 29, 2023
Rickk137
added a commit
that referenced
this pull request
Oct 3, 2023
* SOV-2756: Clean up Babelfish token config (#592) * chore: Clean up Babelfish token config * Create big-grapes-stare.md * SOV-2992: lending withdraw with max amount issue (#593) * fix: lending withdraw with max amount issue * Create polite-apples-taste.md --------- Co-authored-by: Peiman <[email protected]> Co-authored-by: Peiman <[email protected]> * SOV-2942: fix adjust stake data refresh (#582) * fix: adjust stake data refresh * Create six-tips-tease.md * fix: resolve PR comments * SOV-2993: Vesting reward history (#577) * SOV-2993: Vesting reward history * Create nervous-brooms-guess.md * chore: update amount renderer * SOV-3077: Prevent reward SOV claiming (#606) * chore: add missed data-attr * SOV-3077: update claim button logic * Create thin-jobs-pull.md * chore: update changeset --------- Co-authored-by: soulBit <[email protected]> * SOV-3021: update tooltip component (#595) * SOV-2913: vesting delegate history (#588) * feat: vesting delegate history * Create pretty-starfishes-collect.md * feat: filter out delegate changes without previous delegee --------- Co-authored-by: soulBit <[email protected]> * Version Packages (#594) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * SOV-2787: updated notification service api (#553) * feat: updated notification service api * Create soft-birds-hunt.md * SOV-3117: reward claiming (#550) * feat: improved fee quering * feat: claim all rewards with single tx * feat: implement new rewards withdrawal feature * fix: review comments * fix: increase withdrawable checkpoints * fix: show single btc token * fix: show no reward row if there is no fees * Version Packages (#615) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: soulBit <[email protected]> Co-authored-by: Pietro Maximoff <[email protected]> Co-authored-by: Victor Creed <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sovryn.atlassian.net/browse/SOV-2799
https://sovryn.atlassian.net/browse/SOV-3117