Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make charts bigger on larger screens #1042

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Make charts bigger on larger screens #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bc8c77
Make charts bigger on larger screens
tiltom Oct 30, 2024
a46eda0
Create tasty-ads-melt.md
tiltom Oct 30, 2024
9e5464c
feat: expand convert page panel
creed-victor Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tasty-ads-melt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"frontend": patch
---

Make charts bigger on larger screens
2 changes: 1 addition & 1 deletion apps/frontend/src/app/2_molecules/TradingChart/TradingChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const TradingChart: FC<TradingChartProps> = ({ pair }) => {
}, [chart, hasCharts, pair]);

return (
<div className="lg:mt-12 mt-6 w-full p-0 sm:border sm:border-gray-50 sm:rounded sm:p-6 sm:bg-gray-90">
<div className="w-full p-0 sm:border sm:border-gray-50 sm:rounded sm:p-6 sm:bg-gray-90">
<div ref={chartContainerRef} className="h-full min-h-96" />
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions apps/frontend/src/app/5_pages/ConvertPage/ConvertPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,10 +625,10 @@ const ConvertPage: FC = () => {
{t(pageTranslations.subtitle)}
</Paragraph>

<div className="flex flex-col-reverse lg:flex-row lg:space-x-6 xl:w-9/12 w-full">
<div className="flex flex-col-reverse lg:flex-row lg:space-x-6 xl:w-9/12 w-full h-full mt-6 lg:mt-12">
<TradingChart pair={renderPair} />

<div className="lg:mt-12 mt-6 p-0 sm:border sm:border-gray-50 sm:rounded lg:min-w-[28rem] sm:p-6 sm:bg-gray-90">
<div className="p-0 sm:border sm:border-gray-50 sm:rounded lg:min-w-[28rem] sm:p-6 sm:bg-gray-90 self-start h-full">
<div className="bg-gray-80 rounded p-6">
<div className="w-full flex flex-row justify-between items-center">
<Paragraph size={ParagraphSize.base} className="font-medium">
Expand Down
Loading