Rootstock stg #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set specific cypress version * Add timeouts for test jobs
* fix: Show approval editor for ERC721 approvals * fix: Adjust title * fix: Try to fetch ERC721 symbol, remove flag and use built-in type * fix: Add # prefix so its clearer that it is a token id
* Add ls keys * Add logout steps
* Feat: redesign tx details * Prettier * Refactor: use DecodedData in tx modal * Use DecodedData in SingleTxDecoded * Decoded data in tx flow * NamedAddressInfo + show details for spending limits * Fix tests * Restore tooltip and error message * Update src/components/transactions/TxDetails/TxData/DecodedData/MethodCall.tsx Co-authored-by: Usame Algan <[email protected]> * PR comments * Fix test * Delete calls * Interacted with * Creation tx border * Multisend * Hexdata * Fix test * 8 -> 10 * Rm "delegate" from MethodCall * trustedDelegateCallTarget * feat: redesign HexEncodedData (#3990) * feat: redesign HexEncodedData * fix: rephrase tooltip Co-authored-by: katspaugh <[email protected]> * fix: remove monospace --------- Co-authored-by: katspaugh <[email protected]> * Always return something from DecodedData * Fix e2e test * Always show to address * Learn more link * Do not show MethodCall in advanced details if no method * Show TxData in SignOrExecute * Fix e2e test * Fix e2e test * Fix e2e test * Rounded border for decoded data in tx modal * Restore method name * Restore safeTxHash position * Fix tx builder test * Send/Interact with style * Always show avatar in MethodCall * Fix wrapping on mobile * Fix: restore safe app icon for batches * Move Module info up * Zero-width space in hexData * Fix batch e2e test * Move multisend down * Rm unnecessary SignOrExecuteForm changes --------- Co-authored-by: Usame Algan <[email protected]> Co-authored-by: Manuel Gellfart <[email protected]>
…creens (#4033) * Fix: Send wrapping on small screens; multisend position in tx details * 1200px overlap
* Spending limits tests
* Feat: total asset value cents in grey * Adjust for currency-first locales * Inherit font weight
* feat: Import and export counterfactual safes * fix: Wording * fix: Calculate undeployed safes count across networks
* feat: allow users to hide Safe Pass promotion * fix: review issues * fix: rephrase event * fix: adjust button / link positions --------- Co-authored-by: katspaugh <[email protected]>
* Add production tests
* Analytcs: restore WalletConnect tx origin * Fix tests * Rm redundant dev/prod branching
* Analytcs: execution via role event * Execute via spending limit * Extend to TX_CREATED
…n [SW-100] (#3907) * fix: filter imitation txs with trusted tokens * update gateway sdk * fix: create separate params for hiding trusted and imitation transactions * fix: separate untrusted and imitation filters in getTxHistory and getFilteredTxHistory * tests: update unit tests for fetchFilteredTxHistory * fix: remove unecessary default value
- new hidden route `/new-safe/advanced-create` for advanced Safe creation that allows changing masterCopy and saltNonce - refactors safe creation status and pending safe creation handling slightly to work better with multiple flows.
* Fix: for approvals, move method call to advanced details * Fix: restore "native transfer"; wrap "Interacted with" (#4060) * Approval check * FieldsGrid wrap
…997) * add create account function * feat: add enable sign in banner * feat: make banner dismissable * rename banner * update siging message * Use createAccount and getAccount from gateway-sdk * Add banner to storybook, remove from dashboard * fix: use logError * Update src/services/exceptions/ErrorCodes.ts Co-authored-by: katspaugh <[email protected]> --------- Co-authored-by: katspaugh <[email protected]>
* Fix: native transfer only if value > 0 * Hide Advanced details and Tx checks for Rejection txs
* fix: Remove swap and SAP banner * fix: Remove unused events
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links) from 8.0.6 to 8.3.4. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v8.3.4/code/addons/links) --- updated-dependencies: - dependency-name: "@storybook/addon-links" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* refactor: Update StakingBanner link query parameters Link to the apps page filtered by "staking" category * fix: banner button size for mobile screen * refactor: Update StakingBanner component to allow custom hideLocalStorageKey Use different local storage keys for banner on dashboard. That way, if the "Don't show again" button is clicked, the banner is only hidden on the dashboard, but not on the assets page (and vice versa) * fix: button width when being hovered
* Hide suspicious transactions by default * Only default if `undefined` * Update E2E test * Fix E2E
* feat: add outreach popup * feat: add close and ask again later funcitonality * Feat: finish implementing design of outreach popup. * refactor: extract getUpdatedUserActivity to utils * fix: mobile popup styles * fix: do not show at the same time as cookie banner * fix: fix dark mode styles * Chore: add tracking to outreach banner * fix: mock cookie banner state in unit tests * tests: add unit tests for utils * fix: update import * feat: use light theme also in dark mode * feat: ask again after 24 hours or after current session * remove unused utils * feat: only show banner if the safe is targeted for the current outreach and has not already clicked the CTA * use faker for ethereum addresses in the tests * fix: cache getSubmission result to avoid multiple requests * fix: some non targeted safes showing banner
* fix: Refetch submission data when submitting submission * fix: Use mutation for createSubmission and invalidate cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist