Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOV-2938 add wrbtc & iwrbtc address in feeSharing storage #519

Merged
merged 5 commits into from
Sep 20, 2023
Merged

SOV-2938 add wrbtc & iwrbtc address in feeSharing storage #519

merged 5 commits into from
Sep 20, 2023

Conversation

cwsnt
Copy link
Contributor

@cwsnt cwsnt commented Sep 17, 2023

No description provided.

tjcloa
tjcloa requested changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few improvements requested

contracts/governance/FeeSharingCollector/FeeSharingCollectorStorage.sol Outdated Show resolved Hide resolved
contracts/governance/FeeSharingCollector/FeeSharingCollector.sol Outdated Show resolved Hide resolved
contracts/governance/FeeSharingCollector/FeeSharingCollector.sol Show resolved Hide resolved
contracts/governance/FeeSharingCollector/FeeSharingCollector.sol Show resolved Hide resolved
tjcloa
tjcloa requested changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@tjcloa tjcloa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add scripts to create multisig txs to initialize the addresses

@cwsnt
Copy link
Contributor Author

cwsnt commented Sep 20, 2023

pls add scripts to create multisig txs to initialize the addresses

Added the initialization script

@cwsnt cwsnt requested a review from tjcloa September 20, 2023 02:54
@cwsnt cwsnt merged commit dbb2122 into development Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjcloa tjcloa tjcloa approved these changes

@ororopickpocket ororopickpocket ororopickpocket approved these changes

Assignees

@cwsnt cwsnt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwsnt @ororopickpocket @tjcloa