SOV-585 transfer the contract guardianship #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsnt
reviewed
Aug 21, 2023
scripts/sip/sip_interaction.py
Outdated
| data1 = stakingLogic.addPauser.encode_input(newGuardian) | ||
| data2 = stakingLogic.removePauser.encode_input(contracts['multisig']) | ||
| datas = ["0x" + data1[10:], "0x" + data2[10:]] | ||
| description = "SIP-0042: Staking Security Update, Details: https://github.com/DistributedCollective/SIPS/blob/7c1a44b/SIP-0042.md, sha256: 522e1e65c49ec028d81c3a1f94a47354c2f6287c2d90c6eec8f06dcc17a1ebcc" |
There was a problem hiding this comment.
Probably need to add todo mark here, since we need to update the description as well later?
There was a problem hiding this comment.
you're right. done
cwsnt
reviewed
Aug 21, 2023
Going forward you're probably right. I won't change it in this PR though. It will be yours and Tyrones choice to either go ahead with the prepared sip creation script ot transcribe it to hardhat |
cwsnt
approved these changes
Sep 19, 2023
tjcloa
added a commit
that referenced
this pull request
Feb 10, 2024
## Key updates list * SOV-2704-three-years-team-vestings (#508) * SOV-2552 staking foundry fuzzy testing (#513) * SOV-585 transfer the contract guardianship (#514) * feature: add script to transfer amm ownership to governance (#450) * SOV-3436-Proton-release Move sovrynSwapsImpl to internal protocol module and public functions to a protocol module SwapsImplSovrynSwapModule. Includes SOV-3497 Refactor SovrynSwapsImpl. Deployment via bitocracy - SIP-0073. * SOV-3613 Electron release * SOV-3613: adding LoanOpenings and SwapsImplSovrynSwapLib deployment objects for integrated QA tests * SOV-3613: adding VestingFactory and VestingLogic deployment objects for integretaed QA tests * SOV-3161 Increase borrowing debt fix * SOV-625 remove governance withdraw tokens remove governanceWithdrawTokens from vestingLogic using vesting start date to start withdrawal introduce partial withdraw tokens in vesting contract --------- Co-authored-by: ororopickpocket <[email protected]> Co-authored-by: Santo Sinar Pandean <[email protected]> Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Ororo Pickpocket <[email protected]> Co-authored-by: cwsnt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIP-0047 and transfer guardianship to the Contracts Guardian Safe multisig