Feature/update cancel team vesting #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwsnt
changed the base branch from
development
to
refactoring/staking-contract-eip170
cwsnt
changed the title
|
@cwsnt looks good in general, but could you please just add comments with the test case description from here: https://sovryn.atlassian.net/jira/software/c/projects/SOV/boards/4?modal=detail&selectedIssue=SOV-1236 to the places in the code where these test cases are being checked? this would make the review much easier. |
jameshowlett977
suggested changes
Jan 30, 2023
The requirement based on the discussion and attached in jira is we want to make the function executable even if the contract is paused |
jameshowlett977
approved these changes
Jan 30, 2023
ororopickpocket
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.