Fix/staking stake #476
Merged
Fix/staking stake #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ororopickpocket
approved these changes
Jan 19, 2023
tjcloa
reviewed
Jan 20, 2023
There was a problem hiding this comment.
pls see inline comments
also as a general suggestion
in all tests added, pls consider fuzzy testing approach - validating staking with all possible combinations of msg.sender, stakeFor and delegatee - equal/not equal and zero address combinations (except for ad-hoc tests validating specific values like only stakeFor equals to zero etc.)
|
I marked all the tests I'm going to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sovryn.atlassian.net/browse/SOV-1230