-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Staking contract (met dragons - eip170) #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The modules make sense, documentation is clear. There are only a few things I noticed.
- The stakeBySchedule function was not refactored as expected (details in comment). I recommend refactoring this in a separate PR.
- The error messages were shortened to error codes in the past due to the contract size issue. i would prefer for them to be restored to their full length, because it makes debugging a lot easier.
add script for registering vesting detail in registry
remove unused event
improve storage variable naming for vesting creation type
All done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored require/revert messages to their full text
I have only minor comments about error messages.
contracts/governance/Staking/modules/StakingGovernanceModule.sol
Outdated
Show resolved
Hide resolved
contracts/governance/Staking/modules/StakingGovernanceModule.sol
Outdated
Show resolved
Hide resolved
contracts/governance/Staking/modules/StakingGovernanceModule.sol
Outdated
Show resolved
Hide resolved
contracts/governance/Staking/modules/StakingGovernanceModule.sol
Outdated
Show resolved
Hide resolved
… SOV-1724-staking-mainnet-deployment-finalizing-and-testing
…ainnet-deployment-scripts-tested-to-staking-contracts-eip-170 Staking mainnet deployment scripts tested on both testnet and a forked mainnet
Note: original Staking contract and all the inherited ones are left for review/comparison at the moment and will be removed except for IStaking which is adapted to the new structure
isVestingAdress
->isVestingAddress