Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://api.margo.sh/motd.json doesn't know about v20.03.01 release #964

Closed
dmitshur opened this issue Mar 7, 2020 · 3 comments
Closed

Comments

@dmitshur
Copy link

dmitshur commented Mar 7, 2020

This is a very minor issue that I'd like to report. The MOTD message is showing up telling me that a new GoSublime release is available, but in reality I have a more recent release.

Fetching https://api.margo.sh/motd.json right now:

{
	"Message": "★★ New GoSublime Release ★ https://margo.sh/cl/20.2.1 ★★",
	"Error": "",
	"ANN": {
		"Tag": {
			"Y": 20,
			"M": 2,
			"D": 1,
			"N": 1
		},
		"Content": "\nThis release focuses on fixing a performance issue due to a failure to resetting all cached data prematurely.\n- Cache some files in memory to avoid re-reading from disk every time.\n- The `\u0026nodejs.PackageScripts{}` reducer now uses `yarn` instead of `npm` if the `yarn.lock` file is present."
	},
	"Tag": "20.02.01-1"
}

According to https://github.com/DisposaBoy/GoSublime/releases, the latest release is v20.03.01, released 6 days ago.

This causes the "new release" message to continuously show up, despite me having a newer version installed:

image

image

@dmitshur
Copy link
Author

dmitshur commented Mar 7, 2020

The current logic in motd.go is to show the announcement whenever the installed GoSublime version doesn't match what's reported by the motd.json endpoint:

case res.Tag != ctag:
act.msg = res.Message

That means it displays the message when the installed GoSublime version is either newer or older.

@DisposaBoy
Copy link
Owner

Thanks for spotting that!
The motd.json should now be fixed. I'll fix the tag check soon.

@dmitshur
Copy link
Author

dmitshur commented Mar 7, 2020

Thank you @DisposaBoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants