-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add parameter info to disnake.ext.commands.Bot.run() docstring #1240
Conversation
Signed-off-by: Nerd Bear <[email protected]>
Signed-off-by: Nerd Bear <[email protected]>
Co-authored-by: shiftinv <[email protected]> Signed-off-by: Nerd Bear <[email protected]>
I commit the first change request and added a manual commit however it seems it still shows the change request pending. @shiftinv |
As well that the after only signing off on the changes that you requested, the required Lint & Test / check (pull_request) test is failing. please advise |
That's normal, it'll go away in the next round of reviews.
That's because you most likely didn't follow the Contributing.md guide I suggest to read and follow what's stated in that guide. Regardless of that you can follow these steps:
After following these steps run this other command: pre-commit run The next time you'll commit your changes the formatting will happen automatically. After you having ran the command you can push the changes, they are formatting changes. |
It seems that all required checks are now passing and some non-required checks/tests are too except the required one, I ran pre_commit many times and check that its working but with no luck :( @shiftinv Btw may I ask when the next round of reviews are? |
You still didn't format your local code. Run the The next reviews will be whenewer the reviewers have time to review the PR. |
@shiftinv sorry for bothering so much, just wanted to let you know that all required and not required tests are passing. I fixed the PR title amongst some other things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Summary
The class method run() for the class disnake.ext.commands.Bot did not have any information on what parameters it has. This is a quite small change but quite important as nearly all disnake bots use this method to start the bot. If people don't read the docs or simply just are new, they might not know what to pass.
Checklist
pdm lint
pdm pyright