Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cog): fix typing of cog check methods #1232

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

Snipy7374
Copy link
Collaborator

@Snipy7374 Snipy7374 commented Aug 29, 2024

Summary

Basically the check methods on commands.Cog were documented to be either a normal function or a Coroutine, though this wasn't reflexed on the typing part. This PR fixes that issue, refer to the attached image for clarifications.

image

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: refactor/typing/lint Refactors, typing changes and/or linting changes t: bugfix skip news labels Aug 29, 2024
@shiftinv
Copy link
Member

These type hints can be simplified to MaybeCoro[bool], which is equivalent.
other than that, lgtm :shipit:

@shiftinv shiftinv merged commit 2206241 into DisnakeDev:master Aug 31, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: bugfix t: refactor/typing/lint Refactors, typing changes and/or linting changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants