Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: resolve importlib-metadata errors #1208

Merged
merged 3 commits into from
Jul 18, 2024
Merged

ci: resolve importlib-metadata errors #1208

merged 3 commits into from
Jul 18, 2024

Conversation

shiftinv
Copy link
Member

Summary

Both pdm and twine depend on importlib-metadata, but broke due to a change in importlib-metadata v8.0.0.
Since updating pdm is rather tricky, we just pin importlib-metadata<8 there for now:tm:.
In the case of twine, v5.1.1 no longer has this issue (and funnily enough, neither does 5.0.0, but 5.1.0 does).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added t: dependencies Addition/update/removal of dependencies t: meta Changes to the project itself (CI, configs, etc.) t: bugfix skip news labels Jul 18, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Jul 18, 2024
@shiftinv shiftinv requested a review from a team as a code owner July 18, 2024 20:03
@shiftinv shiftinv merged commit 9383d15 into master Jul 18, 2024
33 of 34 checks passed
@shiftinv shiftinv deleted the ci/fix-importlib branch July 18, 2024 20:09
shiftinv added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: bugfix t: dependencies Addition/update/removal of dependencies t: meta Changes to the project itself (CI, configs, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant