Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchorable Header not visible in generic theme for v4.60 #309

Closed
dgosbell opened this issue Nov 17, 2021 · 3 comments
Closed

Anchorable Header not visible in generic theme for v4.60 #309

dgosbell opened this issue Nov 17, 2021 · 3 comments

Comments

@dgosbell
Copy link
Contributor

There seems to be a bug in the generic template in the current 4.60 release where it does not display the Header for Anchorable panes

If I comment out the Theme in the TestApp in the following lines the Anchorable header disappears

<DockingManager.Theme>
<Vs2013LightTheme />
</DockingManager.Theme>

Here is a screenshot showing the Generic cs the VS2103Light theme side by side
image

I've temporarily fixed this by rolling back to the 4.50 release which does not have this problem

@ronaldvanmanen
Copy link

It seems that 4.50.3 was the last version that did not have this problem and that it was introduced in 4.51.1.

@romen-h
Copy link

romen-h commented Dec 8, 2021

Just remove the key from the style for AnchorablePaneTitle.

I also found the commit that broke this and commented on it.

@dgosbell
Copy link
Contributor Author

dgosbell commented Dec 9, 2021

good pickup @romen-h we could either remove the key or add an empty style without a key which is BasedOn the existing style. If I get time this weekend I might do a pull request for that second approach since it allows for the end user to easily re-use and extend the style that comes with the control.

Dirkster99 added a commit that referenced this issue Jul 16, 2022
Fixes #309 Anchorable Header not visible in generic theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants