Refactor flexbox algorithm into smaller parts #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to pass them around to the functions implementing each step of the algorithm.
…-flexbox-algorithm
Co-authored-by: Andreas Weibye <[email protected]>
Co-authored-by: Andreas Weibye <[email protected]>
This was referenced Jun 8, 2022
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Extract cache check into new function * Move flexbox algorithm constants to a struct This will make it easier to pass them around to the functions implementing each step of the algorithm. * Fix Clippy error * Move flexbox algorithm step 2 to new function * Move flexbox algorithm step 1 to new function * Move flexbox algorithm step 3 to new function * Move flexbox algorithm step 5 to new function * Move flexbox algorithm step 6 to new function * Move flexbox algorithm step 7 to new function * Move flexbox algorithm step 8 to new function * Move flexbox algorithm step 9 to new function * Move flexbox algorithm step 11 to new function * Fix copy & paste error in documentation * Move flexbox algorithm step 12 to new function * Move flexbox algorithm step 13 to new function * Move flexbox algorithm step 14 to new function * Move flexbox algorithm step 15 to new function * Move flexbox algorithm step 16 to new function * Move flexbox algorithm final layout step to new function * Move flexbox algorithm absolute layout step to new function * Move flexbox algorithm calculate children baseline step to new function * Remove allow(clippy::cognitive_complexity) for flexbox algorithm * Add inline annotations to flexbox algorithm steps * Add TODO Co-authored-by: Andreas Weibye <[email protected]> * Add TODO Co-authored-by: Andreas Weibye <[email protected]> * Fix broken import Co-authored-by: Tim Jentzsch <[email protected]> Co-authored-by: Andreas Weibye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a remake of #47; full credit goes to @TimJentzsch.