Grid: selectively rerun track sizing #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taining percentage sized tracks
nicoburns
force-pushed
the
grid/selectively-rerun-track-sizing
branch
from
496c1a8
to
b8507c2
Compare
alice-i-cecile
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Improve performance of the CSS Grid algorithm. This one was the last one on my list of obvious optimisations.
Improvements
These changes seem to provide modest but consistent improvements (~10%) for our existing benchmark. It also leads to more significant improvements (~50%) for the case where:
minmax(0, 1fr)The 6500 node "deep" benchmark is down to ~8ms with this PR and with all
minmax(0, 1fr)(and ~18ms with a random mix of track types). This is quite a common use case "I want N evenly sized row or columns", so this represents quite a useful fast path.