Allow hooks in the expression of a match statement and if statement

[ealmloff]

Fixes dx check for this code snippet:

if use_signal(|| true) {
     println!("123")
}

match use_signal(|| true) {
    true => println!("false"),
    false => println!("true")
}

And report errors for this code snippet:

use_hook(|| use_signal(|| 0));
spawn(async move { use_signal(|| 0) });

[DogeDark]

Does Rust evaluate every condition in an if statement? E.g.

let some_value = false;

// Would the use_signal still get checked(ran) despite the conditional already failing?
if some_value && use_signal(|| true) {
    println!("123");
}

[ealmloff]

Does Rust evaluate every condition in an if statement? E.g.

let some_value = false;

// Would the use_signal still get checked(ran) despite the conditional already failing?
if some_value && use_signal(|| true) {
    println!("123");
}

No, that case is still unchecked. Compared to if statements and closures, I think it is more rare, but we should lint for that eventually as well. Note it isn't specific to if statements, this code doesn't print anything either:

fn main() {
    let val = false && returns_true();
    assert!(!val)
}

fn returns_true() -> bool {
    panic!("this will not be run")
}

[matthunz]

Looks great! I never thought of using hooks like that but I'm sure I'll give it a go now. I posted #2940 to eventually add specific lints for && and || in if and match