Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Option<T> with non path T types #2808

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Aug 8, 2024

This PR fixes a regression in props where we don't recognize Option<&'static str> as an optional prop breaking this example:

#[derive(Props, Clone, PartialEq)]
pub struct IconProps {
    pub icon: crate::icons::IconKind,
    pub class: Option<&'static str>,
    pub onclick: Option<EventHandler<MouseEvent>>,
}

@ealmloff ealmloff added bug Something isn't working core relating to the core implementation of the virtualdom labels Aug 8, 2024
@jkelleyrtp jkelleyrtp merged commit 0bb81ab into DioxusLabs:main Aug 9, 2024
15 checks passed
@ealmloff ealmloff deleted the fix-option-str branch August 9, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core relating to the core implementation of the virtualdom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants