Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form inputs, form submits navigating, file drop, multiple root elements #1974

Merged
merged 45 commits into from
Mar 7, 2024

Conversation

jkelleyrtp
Copy link
Member

@jkelleyrtp jkelleyrtp commented Feb 24, 2024

Fix
#1921
#1922
#1972
#1963
#1907
#1826
#1950

  • fix RFD
  • Migrate to typescript + bun
  • FormInputs
  • Navigating
  • tests for all

Add test cases for each of these.
Adds typescript support for the interpreter.
Unifies binary protocol with its base host

This should clean up our interpreter code and fix a number of longstanding issues around eventhandling across the boundary.

We still don't have a great solution for liveview.

Wry let's us intercept navigations now, too, which should make accidental navigates impossible.

@jkelleyrtp jkelleyrtp changed the title Fix form inputs, form submits navigating, file drop Fix form inputs, form submits navigating, file drop, multiple root elements Feb 24, 2024
@jkelleyrtp jkelleyrtp changed the title Fix form inputs, form submits navigating, file drop, multiple root elements Fix form inputs, form submits navigating, file drop, multiple root elements, (attempt) synchronous prevent default Feb 26, 2024
@jkelleyrtp jkelleyrtp changed the title Fix form inputs, form submits navigating, file drop, multiple root elements, (attempt) synchronous prevent default Fix form inputs, form submits navigating, file drop, multiple root elements, synchronous prevent default Feb 27, 2024
@jkelleyrtp jkelleyrtp changed the title Fix form inputs, form submits navigating, file drop, multiple root elements, synchronous prevent default Fix form inputs, form submits navigating, file drop, flatten fileengine multiple root elements, synchronous prevent default Feb 27, 2024
@jkelleyrtp jkelleyrtp changed the title Fix form inputs, form submits navigating, file drop, flatten fileengine multiple root elements, synchronous prevent default Fix form inputs, form submits navigating, file drop Mar 2, 2024
@jkelleyrtp jkelleyrtp marked this pull request as ready for review March 5, 2024 20:16
@jkelleyrtp jkelleyrtp changed the title Fix form inputs, form submits navigating, file drop Fix form inputs, form submits navigating, file drop, multiple root elements Mar 6, 2024
@jkelleyrtp
Copy link
Member Author

jkelleyrtp commented Mar 6, 2024

Going to leave synchronous events for a separate PR as it will need to touch core for event dispatching through the runtime.

@jkelleyrtp jkelleyrtp merged commit 6faa51a into main Mar 7, 2024
9 checks passed
@jkelleyrtp jkelleyrtp deleted the jk/fix-form-inputs branch March 7, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants