Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related to #1547: use dioxus-cli within a workspace (wildcard-members, real package names) #1642

Commits on Nov 15, 2023

  1. Related to DioxusLabs#1547: use dioxus-cli within a workspace

    Although the `dx` CLI allows to specify a package name to chose from workspace members,
    it does not support workspace members specified as glob-wildcards.
    Neither it respects the effective package name, specified in the crate's `Cargo.toml`.
    
    This PR addresses that issue:
    - upon `dx build ...`, if the `--bin` CLI-argument is provided, treat the current dir as a workspace;
    - search through the workspace's `members`: resolve each of them with `glob`;
    - assume that any workspace member has a `Cargo.toml` in it (cargo does it, so it's okay);
    - read said manifest, and check the package name in it;
    - if found — there we have our sought package.
    RGafiyatullin committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ad5efc6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57679b3 View commit details
    Browse the repository at this point in the history
  3. glob is unused

    RGafiyatullin committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0b58d3f View commit details
    Browse the repository at this point in the history