Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Read value from root when calling AtomState::current() #1609

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: Read value from root when calling AtomState::current() #1609

merged 1 commit into from
Nov 4, 2023

Conversation

marc2332
Copy link
Contributor

@marc2332 marc2332 commented Nov 4, 2023

Fixes #1608

This will make AtomState::current() read from the Root value instead of the AtomState inner value, this makes it work properly on async contexts / event handlers

@marc2332 marc2332 mentioned this pull request Nov 4, 2023
Closed
ealmloff
ealmloff approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@ealmloff ealmloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ealmloff ealmloff merged commit bb5738a into DioxusLabs:master Nov 4, 2023
10 checks passed
@marc2332 marc2332 deleted the patch-11 branch November 4, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AtomState::current() doesn't return the current value
2 participants
@marc2332 @ealmloff