Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launch functions pub #1288

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Make launch functions pub #1288

merged 2 commits into from
Aug 9, 2023

Conversation

CodedNil
Copy link
Contributor

@CodedNil CodedNil commented Aug 3, 2023

I am currently working on a project where I need to run server-side code concurrently with Dioxus Fullstack. However, I noticed that there is no way to reuse the Tokio runtime created in the launch function. As a result, the only option available to me right now is to spawn a new thread and runtime, which seems inefficient.

I propose making the launch functions public. This would allow developers like me to copy the launch function's code into our codebases and manipulate the Tokio runtime as needed, such as spawning new functions onto it. This change would provide more flexibility and efficiency in running concurrent server-side code.

@ealmloff ealmloff enabled auto-merge (squash) August 9, 2023 16:23
@ealmloff ealmloff merged commit 92a8669 into DioxusLabs:master Aug 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants