Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject all external routes when parsing a route #1272

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Reject all external routes when parsing a route #1272

merged 2 commits into from
Aug 1, 2023

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Aug 1, 2023

Reject any routes that don't start with / when parsing a route in the enum router macro

@ealmloff ealmloff added bug Something isn't working router Related to the router implementation labels Aug 1, 2023
@ealmloff ealmloff marked this pull request as draft August 1, 2023 16:42
@ealmloff ealmloff marked this pull request as ready for review August 1, 2023 16:50
@ealmloff ealmloff merged commit 61ce3dd into DioxusLabs:master Aug 1, 2023
@jkelleyrtp jkelleyrtp mentioned this pull request Aug 1, 2023
Merged
jkelleyrtp added a commit that referenced this pull request Aug 1, 2023
@jkelleyrtp
Bump the router to include #1272
7c6bb27
@pyrrho pyrrho mentioned this pull request May 2, 2024
Merged
@ealmloff ealmloff deleted the reject-external-routes branch May 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkelleyrtp jkelleyrtp jkelleyrtp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working router Related to the router implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ealmloff @jkelleyrtp