revision: gate kill_all behind windows

DioxusLabs · Nov 21, 2024 · 81eff21 · 81eff21
1 parent 60329f2
commit 81eff21
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/packages/cli/src/serve/mod.rs b/packages/cli/src/serve/mod.rs
@@ -107,8 +107,10 @@ pub(crate) async fn serve_all(mut args: ServeArgs) -> Result<()> {
                 } else if runner.should_full_rebuild {
                     tracing::info!(dx_src = ?TraceSrc::Dev, "Full rebuild: {}", file);
 
-                    // Kill any running executables
-                    runner.kill_all();
+                    // Kill any running executables on Windows
+                    if cfg!(windows) {
+                        runner.kill_all();
+                    }
 
                     // We're going to kick off a new build, interrupting the current build if it's ongoing
                     builder.rebuild(args.build_arguments.clone());
@@ -217,7 +219,12 @@ pub(crate) async fn serve_all(mut args: ServeArgs) -> Result<()> {
                 // `Full rebuild:` to line up with
                 // `Hotreloading:` to keep the alignment during long edit sessions
                 tracing::info!("Full rebuild: triggered manually");
-                runner.kill_all();
+
+                // Kill any running executables on Windows
+                if cfg!(windows) {
+                    runner.kill_all();
+                }
+
                 builder.rebuild(args.build_arguments.clone());
                 runner.file_map.force_rebuild();
                 devserver.start_build().await