Feature/help coins balance #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitalyKrenel
approved these changes
Nov 28, 2020
| @@ -2,14 +2,14 @@ import React from 'react' | |||
| import SignOutIcon from '../assets/sign-out.svg' | |||
|
|
|||
| function CardAvatar({ user, onSignOut }) { | |||
| const {name, image} = user | |||
| const {name, image, coins} = user | |||
There was a problem hiding this comment.
Keep in mind, that user is potentially often encountered prop in your app, so it may make sense to move to some react context.
Otherwise, you may find yourself dealing with props drilling - when you need to pass some props way down the React tree just to pass them to some low level component.
|
How do you feel about adding Netlify to your project? This way the deployed version of the app will be available for each branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to allow children to see the balance help coins. At the moment the help coins balance can only be read from Firestore. The value needs to be manually changed from Firestore.