Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade: upgrade typescript to 4.2.2 #2514

Closed
wants to merge 3 commits into from
Closed

upgrade: upgrade typescript to 4.2.2 #2514

wants to merge 3 commits into from

Conversation

nuanyang233
Copy link
Collaborator

No description provided.

@nuanyang233
Copy link
Collaborator Author

Compile after upgrading and get an error:

Error: Debug Failure.
    at Object.getModuleSpecifiers (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:91587:30)
    at getSpecifierForModuleSymbol (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:39998:62)
    at createExpressionFromSymbolChain (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:40172:63)
    at symbolToExpression (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:40159:24)
    at /Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:38966:106
    at withContext (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:39005:37)
    at symbolToExpression (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:38966:28)
    at symbolToStringWorker (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:38886:30)
    at Object.usingSingleLineStringWriter (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:10151:13)
    at symbolToString (/Maskbook/node_modules/.pnpm/[email protected]/node_modules/typescript/lib/tsc.js:38884:73)

@nuanyang233
Copy link
Collaborator Author

#43011

@Jack-Works
Copy link
Member

let's wait for 4.2.3 release

@Jack-Works
Copy link
Member

Jack-Works commented Mar 5, 2021 •
edited
Loading

cannot upgrade to 4.2.3 cause microsoft/TypeScript#43098

let's wait for 4.2.4 or ts-results fix

@Jack-Works
Copy link
Member

now blocked by vultix/ts-results#20

@Jack-Works Jack-Works mentioned this pull request Apr 20, 2021
Merged
@Jack-Works Jack-Works deleted the feature/upgrade-typescript branch June 24, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuanyang233 @Jack-Works