refactor: redpacket history #2374

zhouhanseng · 2021-02-08T14:11:02Z

packages/maskbook/src/plugins/RedPacket/UI/RedPacketInList.tsx

packages/maskbook/src/_locales/en/messages.json

septs · 2021-02-09T14:33:23Z

After this PR merged, do i need to stop the older service?

https://service.r2d2.to/red-packet-history

CC @guanbinrui

Tedko · 2021-02-13T09:48:43Z

After this PR merged, do i need to stop the older service?
https://service.r2d2.to/red-packet-history
CC @guanbinrui

keep it running for a while just in case

Jack-Works · 2021-02-13T12:02:29Z

packages/maskbook/src/plugins/RedPacket/database.ts

+export async function getRedPacketsHistory(rpids: string[]) {
+    const records: RedPacketRecord[] = []
+    for await (const record of RedPacketDatabase.iterate('red-packet')) {
+        if (rpids.includes(record.payload.rpid)) records.push(RedPacketRecordOutDB(record))


is it possible to have multiple records with the same rpid?

No, each record has its only rpid.

so why don't you get record by RedPacketDatabase.get?

the last question @zhouhanseng

if you can query via .get plz use it instead of iterate over the database. it's O1 (hash table)

cc @zhouhanseng

packages/maskbook/src/plugins/RedPacket/hooks/useAllRedPackets.ts

packages/maskbook/src/plugins/ITO/UI/StyledLinearProgress.tsx

packages/maskbook/src/plugins/RedPacket/services.ts

packages/maskbook/src/plugins/RedPacket/UI/RedPacketInList.tsx

packages/maskbook/src/plugins/ITO/UI/StyledLinearProgress.tsx

Jack-Works · 2021-02-18T08:11:04Z

packages/maskbook/src/plugins/RedPacket/database.ts

+export async function getRedPacketsHistory(rpids: string[]) {
+    const records: RedPacketRecord[] = []
+    for await (const record of RedPacketDatabase.iterate('red-packet')) {
+        if (rpids.includes(record.payload.rpid)) records.push(RedPacketRecordOutDB(record))


so why don't you get record by RedPacketDatabase.get?

Jack-Works

lgtm on code style

Jack-Works · 2021-02-18T15:03:12Z

oh wait

Jack-Works · 2021-02-18T15:03:37Z

here is confliction
still have some old review not resolved

guanbinrui · 2021-02-18T15:18:08Z

packages/maskbook/src/plugins/RedPacket/services.ts

+    const redPacketsFromDB = await database.getRedPacketsHistory(redPacketsFromChain.map((x) => x.rpid))
+    return redPacketsFromChain.reduce((acc, history) => {
+        const record = redPacketsFromDB.find((y) => y.payload.rpid === history.rpid)
+        if (history.chain_id === chainId && record) {


Check history.chain_id === chainId at first and if it's true the finding logic can be ommited.

It can't be ommited since we need password.

Tedko · 2021-02-27T05:46:36Z

How's it? @zhouhanseng @septs @Jack-Works

zhouhanseng · 2021-03-01T02:16:29Z

@Tedko work on this today.

Jack-Works · 2021-03-03T03:27:48Z

packages/maskbook/src/plugins/RedPacket/types.ts

 export interface RedPacketAvailability {
    token_address: string
    balance: string
    total: string
    claimed: string
    expired: boolean
-    ifclaimed: boolean
+    claimed_amount: string


is it a breaking change?

yes, already handled it:

Maskbook/packages/maskbook/src/plugins/RedPacket/hooks/useAvailabilityComputed.ts

Line 32 in 8accb67

const isClaimed = availability.claimed_amount !== '0'

I mean how do you handle the old name ifclaimed

const isClaimed = availability.ifclaimed => const isClaimed = availability.claimed_amount !== '0'

So IIRC the field "ifclaimed" is actually used in the payload. did it changed too?

ifclaimed does not exist in payload

zhouhanseng · 2021-03-05T08:18:38Z

packages/maskbook/src/plugins/RedPacket/schema.json

@@ -14,6 +10,10 @@
            "type": "string",
            "title": "rpid"
        },
+        "txid": {


It is not breaking change, since additionalProperties is true and "contract_version" is removed from "required" field, old red-packet payload is compatible.

zhouhanseng · 2021-03-05T10:04:43Z

packages/maskbook/src/plugins/RedPacket/services.ts

-    const redPacketsFromDB = await database.getRedPacketsHistory(redPacketsFromChain.map((x) => x.txid))
-    return redPacketsFromChain.reduce((acc, history) => {
-        const record = redPacketsFromDB.find((y) => y.id === history.txid)
+    const historys = await subgraph.getRedPacketHistory(address)


simplify this logic

packages/maskbook/src/plugins/RedPacket/contracts/useRedPacketContract.ts

Jack-Works

currently lgtm

Jack-Works · 2021-03-18T03:31:08Z

merge with master. might have some type errors in it

zhouhanseng · 2021-03-18T04:37:47Z

@Jack-Works Notice don't merge into master before mainnet contract deployed.

Jack-Works

lgtm on style

contract that applies improvements on gas

close #3193

…window

AinuX · 2021-06-06T14:31:21Z

Test passed with ETH MainNet.

septs · 2021-06-06T18:27:17Z

packages/maskbook/src/plugins/Ethereum/UI/TransactionDialog.tsx

+                                          state.error.code <= JSON_RPC_ErrorCode.SERVER_ERROR_RANGE_START &&
+                                          state.error.code >= JSON_RPC_ErrorCode.SERVER_ERROR_RANGE_END)


plz extract this code snippet as tool function

Jack-Works reviewed Feb 9, 2021

View reviewed changes

packages/maskbook/src/plugins/RedPacket/UI/RedPacketInList.tsx Outdated Show resolved Hide resolved

septs reviewed Feb 9, 2021

View reviewed changes

packages/maskbook/src/_locales/en/messages.json Show resolved Hide resolved

zhouhanseng marked this pull request as ready for review February 10, 2021 07:53

zhouhanseng changed the title ~~wip: redpacket history~~ refactor: redpacket history Feb 10, 2021

Jack-Works requested changes Feb 13, 2021

View reviewed changes

Jack-Works requested changes Feb 18, 2021

View reviewed changes

Jack-Works previously approved these changes Feb 18, 2021

View reviewed changes

guanbinrui reviewed Feb 18, 2021

View reviewed changes

zhouhanseng dismissed Jack-Works’s stale review via 4cfae96 March 1, 2021 08:50

zhouhanseng force-pushed the hancheng/refactor-red-packet-history branch 2 times, most recently from 4cfae96 to 4706fdd Compare March 2, 2021 06:13

Jack-Works reviewed Mar 3, 2021

View reviewed changes

zhouhanseng force-pushed the hancheng/refactor-red-packet-history branch from d01507a to 2f8c80e Compare March 5, 2021 08:16

zhouhanseng commented Mar 5, 2021

View reviewed changes

zhouhanseng force-pushed the hancheng/refactor-red-packet-history branch 2 times, most recently from b3e51a5 to 5e00a2a Compare March 11, 2021 05:07

guanbinrui reviewed Mar 12, 2021

View reviewed changes

packages/maskbook/src/plugins/RedPacket/contracts/useRedPacketContract.ts Show resolved Hide resolved

Jack-Works previously approved these changes Mar 12, 2021

View reviewed changes

Jack-Works dismissed their stale review via d0115b4 March 18, 2021 03:30

Jack-Works previously approved these changes Mar 19, 2021

View reviewed changes

zhouhanseng dismissed Jack-Works’s stale review via 7acf14c March 21, 2021 08:32

septs and others added 20 commits June 6, 2021 15:40

chore: remove unused locale keys

722e2ff

feat: prompt password

3b9f93e

feat: sign password

01c0483

chore: tab name

0f5fad2

chore: add sign cancel msg

7e3674b

fix: rebase error

ffa7e4b

chore: tx hash disable button

7cc53da

chore: prettier

07e3c26

chore: update ropsten contract

44cfa1b

contract that applies improvements on gas

chore: rm duplicated share dialog

6682f96

chore: use twitter name

0d0e4a0

chore: update mainnet contract

fbffac8

chore: update graph name

ecedc10

chore: history button status

5da1623

chore: fix select style

af46719

close #3193

chore: rebase conflict

7395b39

chore: rebase master

de1ec50

chore: reply code review

df01031

fix: "finish" button overlapped in red pack page if zoom out browser …

2dd9170

…window

fix: rebase error

9c42f1b

zhouhanseng force-pushed the hancheng/refactor-red-packet-history branch from 76f6955 to 9c42f1b Compare June 6, 2021 09:38

zhouhanseng added 2 commits June 6, 2021 17:38

chore: for test

df45dbd

chore: rm test

e7cee31

nuanyang233 approved these changes Jun 6, 2021

View reviewed changes

septs reviewed Jun 6, 2021

View reviewed changes

septs approved these changes Jun 6, 2021

View reviewed changes

zhouhanseng merged commit fb2c900 into master Jun 7, 2021

zhouhanseng deleted the hancheng/refactor-red-packet-history branch June 7, 2021 01:25

guanbinrui pushed a commit that referenced this pull request Jun 10, 2021

refactor: redpacket history (#2374)

6e86e03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: redpacket history #2374

refactor: redpacket history #2374

zhouhanseng commented Feb 8, 2021 •

edited

Loading

septs commented Feb 9, 2021

Tedko commented Feb 13, 2021

Jack-Works Feb 13, 2021

zhouhanseng Feb 16, 2021

Jack-Works Feb 18, 2021

Jack-Works Feb 18, 2021

Jack-Works Feb 18, 2021

Jack-Works Feb 27, 2021

Jack-Works Feb 18, 2021

Jack-Works left a comment

Jack-Works commented Feb 18, 2021

Jack-Works commented Feb 18, 2021

guanbinrui Feb 18, 2021 •

edited

Loading

zhouhanseng Mar 3, 2021

Tedko commented Feb 27, 2021

zhouhanseng commented Mar 1, 2021

Jack-Works Mar 3, 2021

zhouhanseng Mar 3, 2021

Jack-Works Mar 3, 2021

zhouhanseng Mar 3, 2021

Jack-Works Mar 3, 2021

zhouhanseng Mar 3, 2021

zhouhanseng Mar 5, 2021 •

edited

Loading

zhouhanseng Mar 5, 2021

Jack-Works left a comment

Jack-Works commented Mar 18, 2021

zhouhanseng commented Mar 18, 2021 •

edited

Loading

Jack-Works left a comment

AinuX commented Jun 6, 2021

septs Jun 6, 2021

		state.error.code <= JSON_RPC_ErrorCode.SERVER_ERROR_RANGE_START &&
		state.error.code >= JSON_RPC_ErrorCode.SERVER_ERROR_RANGE_END)

refactor: redpacket history #2374

refactor: redpacket history #2374

Conversation

zhouhanseng commented Feb 8, 2021 • edited Loading

septs commented Feb 9, 2021

Tedko commented Feb 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jack-Works left a comment

Choose a reason for hiding this comment

Jack-Works commented Feb 18, 2021

Jack-Works commented Feb 18, 2021

guanbinrui Feb 18, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tedko commented Feb 27, 2021

zhouhanseng commented Mar 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhouhanseng Mar 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jack-Works left a comment

Choose a reason for hiding this comment

Jack-Works commented Mar 18, 2021

zhouhanseng commented Mar 18, 2021 • edited Loading

Jack-Works left a comment

Choose a reason for hiding this comment

AinuX commented Jun 6, 2021

Choose a reason for hiding this comment

zhouhanseng commented Feb 8, 2021 •

edited

Loading

guanbinrui Feb 18, 2021 •

edited

Loading

zhouhanseng Mar 5, 2021 •

edited

Loading

zhouhanseng commented Mar 18, 2021 •

edited

Loading