Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugfix for update permission #11642

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: bugfix for update permission #11642

merged 1 commit into from
May 23, 2024

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes #MF-0000

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui merged commit e0f0d92 into release/2.26.0 May 23, 2024
13 of 14 checks passed
@guanbinrui guanbinrui deleted the fix/bugfix-for-update-permission branch May 23, 2024 07:15
guanbinrui added a commit that referenced this pull request May 24, 2024
@guanbinrui @nuanyang233 @Jack-Works
chore: merge 2.26.0 (#11648)
5ce0e10 
* [Release] Hotfix 2.25.0 => 2.25.1 (patch) (#11618)

* chore: bump version to 2.25.1

* fix: mask token order in swap (#11620)

* fix: mismatch number tag (#11624)

* fix: mask token order (#11626)

---------

Co-authored-by: nuanyang233 <[email protected]>

* chore: bump version to 2.26.0

* refactor: support x.com in code (#11634)

* feat: update permission page (#11639)

* feat: update permission page

* chore: reply review

* chore: reply review

* fix: incorrect adaptor name (#11640)

* fix: bugfix for update permission (#11642)

* fix: bugfix for update permission on installed (#11644)

* chore: eslint

---------

Co-authored-by: nuanyang233 <[email protected]>
Co-authored-by: Jack Works <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuanyang233 @guanbinrui