Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugfix for lens #11132

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix: bugfix for lens #11132

merged 1 commit into from
Nov 15, 2023

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes #MF-5599 MF-5600 MF-5602 MF-5603 MF-5598

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.23.10 milestone Nov 15, 2023
@guanbinrui guanbinrui merged commit 456ad6f into hotfix/2.23.10 Nov 15, 2023
15 checks passed
@guanbinrui guanbinrui deleted the fix/bugfix-for-lens branch November 15, 2023 10:14
nuanyang233 added a commit that referenced this pull request Nov 16, 2023
@nuanyang233
fix: bugfix for lens (#11132)
fe74df8
guanbinrui pushed a commit that referenced this pull request Nov 16, 2023
@nuanyang233
chore: pick commits (#11138)
0f1d549 
* feat: upgrade lens (#11124)

* chore: pick commit

* chore: build error

* chore: revert test code

* fix: bugfix for lens (#11132)

* feat: lens sign less api (#11133)

* chore: eslint
guanbinrui added a commit that referenced this pull request Nov 16, 2023
@guanbinrui @nuanyang233
@UncleBill @Jack-Works
[Release] Hotfix 2.23.9 => 2.23.10 (patch) (#11122)
7c44e0d 
* [Release] Hotfix 2.23.9 => 2.23.10 （patch）

* feat: upgrade lens (#11124)

* chore: pick commit

* chore: build error

* chore: revert test code

* fix: mf-5473 lower spam score (#10965)

* fix: bugfix for lens (#11132)

* feat: lens sign less api (#11133)

* fix: unit test (#11139)

* fix: canParse

* Update setups/index.ts

* fix: threads

* refactor: remove patch

---------

Co-authored-by: Jack Works <[email protected]>
Co-authored-by: guanbinrui <[email protected]>
Co-authored-by: guanbinrui <[email protected]>

---------

Co-authored-by: guanbinrui <[email protected]>
Co-authored-by: nuanyang233 <[email protected]>
Co-authored-by: UncleBill <[email protected]>
Co-authored-by: Jack Works <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.10
Development

Successfully merging this pull request may close these issues.
2 participants
@nuanyang233 @guanbinrui