Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: popup setup spinner #11053

Merged
merged 2 commits into from
Oct 30, 2023
Merged

feat: popup setup spinner #11053

merged 2 commits into from
Oct 30, 2023

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes #MF-5480

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 added this to the 2.24.0 milestone Oct 30, 2023
Jack-Works
Jack-Works previously approved these changes Oct 30, 2023
@guanbinrui guanbinrui merged commit b7f4375 into develop Oct 30, 2023
14 checks passed
@guanbinrui guanbinrui deleted the feat/add-popup-spinner-page branch October 30, 2023 15:10
guanbinrui pushed a commit that referenced this pull request Nov 2, 2023
#Conflicts:
#	packages/mask/.webpack/config.ts
guanbinrui pushed a commit that referenced this pull request Nov 3, 2023
#Conflicts:
#	packages/mask/.webpack/config.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants