Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove select language icons #10972

Merged
merged 1 commit into from
Oct 16, 2023
Merged

chore: remove select language icons #10972

merged 1 commit into from
Oct 16, 2023

Conversation

beyond009
Copy link
Contributor

Description

Closes # (NO_ISSUE)
mf-0000

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@beyond009 beyond009 added this to the 2.23.3 milestone Oct 16, 2023
@guanbinrui guanbinrui merged commit 249d79e into hotfix/2.22.3 Oct 16, 2023
13 of 14 checks passed
@guanbinrui guanbinrui deleted the chore/remove-flag branch October 16, 2023 05:04
@guanbinrui guanbinrui restored the chore/remove-flag branch October 17, 2023 03:09
@guanbinrui guanbinrui deleted the chore/remove-flag branch October 17, 2023 03:09
guanbinrui pushed a commit that referenced this pull request Oct 17, 2023
@beyond009 @guanbinrui
chore: remove select language icons (#10972)
5c60595
guanbinrui added a commit that referenced this pull request Oct 17, 2023
@guanbinrui @UncleBill @beyond009
[Release] Hotfix 2.23.2 => 2.23.3 (patch) (#10975)
87182ed 
* chore: update version to 2.22.3

* fix: update pet promote tweet (#10976)

* chore: remove select language icons (#10972)

---------

Co-authored-by: guanbinrui <[email protected]>
Co-authored-by: UncleBill <[email protected]>
Co-authored-by: Harlan Sun <[email protected]>
guanbinrui added a commit that referenced this pull request Oct 17, 2023
@guanbinrui @UncleBill @beyond009
[Release] Hotfix 2.23.2 => 2.23.3 (patch) (#10975)
3359792 
* chore: update version to 2.22.3

* fix: update pet promote tweet (#10976)

* chore: remove select language icons (#10972)

---------

Co-authored-by: guanbinrui <[email protected]>
Co-authored-by: UncleBill <[email protected]>
Co-authored-by: Harlan Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.3
Development

Successfully merging this pull request may close these issues.
2 participants
@beyond009 @guanbinrui