feat: mf-5475 add scroll chain #10971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UncleBill
force-pushed
the
feat/mf-5475-add-scroll
branch
4 times, most recently
from
ca67bdf
to
c8892dc
Compare
|
Remove the white border part. 
|
This was intentionally designed. @xiazhiming |
Not right to me. I see no outline border used in other chain icons. Check here: packages/web3-shared/evm/src/assets. |
|
Please consult @SpaceStation09 to deploy contracts on the scroll chain. |
Jack-Works
previously approved these changes
Oct 17, 2023
guanbinrui
reviewed
Oct 17, 2023
UncleBill
force-pushed
the
feat/mf-5475-add-scroll
branch
from
c8892dc
to
e938873
Compare
Jack-Works
previously approved these changes
Oct 18, 2023
guanbinrui
reviewed
Oct 18, 2023
guanbinrui
reviewed
Oct 18, 2023
UncleBill
force-pushed
the
feat/mf-5475-add-scroll
branch
from
1e197f8
to
99f54bf
Compare
guanbinrui
previously approved these changes
Oct 18, 2023
UncleBill
force-pushed
the
feat/mf-5475-add-scroll
branch
from
99f54bf
to
631b0bd
Compare
guanbinrui
added a commit
that referenced
this pull request
Oct 19, 2023
* chore: bump version to 2.23.4 * chore: change calendar api (#10994) * chore: change calendar api (#10995) * chore: change calendar api * chore: change calendar api * fix: news list same key (#10996) * feat: mf-5475 add scroll chain (#10971) * fix: type error (#10999) * fixup! feat: mf-5475 add scroll chain (#11001) * fix: mf-5520 add debank scroll chain name (#11003) * fix: update scroll icon (#11004) * fixup! fix: update scroll icon (#11004) (#11006) * fix: web3 selector (#11007) * fix: the web3/more injection * refactor: code style * fix: mf-5518 add scroll chain name for rabby (#11008) --------- Co-authored-by: Harlan Sun <[email protected]> Co-authored-by: UncleBill <[email protected]>
guanbinrui
pushed a commit
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mask.atlassian.net/browse/MF-5475