Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local profiles load slowly #10913

Merged
merged 8 commits into from
Oct 8, 2023
Merged

Conversation

beyond009
Copy link
Contributor

Description

Closes # (NO_ISSUE)
https://mask.atlassian.net/browse/MF-5438

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@beyond009 beyond009 added this to the 2.23.0 milestone Oct 8, 2023
Copy link
Contributor

@UncleBill UncleBill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should memo the return list if it would be used as an dependency.

Copy link
Contributor

@UncleBill UncleBill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image `.filter` creates new array, wrap it with `useMemo`

Also the constructed array.

@guanbinrui guanbinrui merged commit 448c35c into release/2.23.0 Oct 8, 2023
13 checks passed
@guanbinrui guanbinrui deleted the fix/contact-detail branch October 8, 2023 10:04
guanbinrui pushed a commit that referenced this pull request Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants