Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bugfix for cloud backup #10827

Merged
merged 3 commits into from
Sep 22, 2023
Merged

fix: bugfix for cloud backup #10827

merged 3 commits into from
Sep 22, 2023

Conversation

nuanyang233
Copy link
Collaborator

@nuanyang233 nuanyang233 commented Sep 22, 2023 •
edited
Loading

Description

Closes #MF-5301 MF-5317 MF-5319 MF-5341 MF-5348 MF-5356 MF-5357 MF-5358 MF-5361

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@nuanyang233 nuanyang233 changed the base branch from develop to release/2.23.0 September 22, 2023 07:54
@nuanyang233 nuanyang233 added this to the 2.23.0 milestone Sep 22, 2023
@nuanyang233 nuanyang233 changed the title Fix/bugfix for cloud backup fix: bugfix for cloud backup Sep 22, 2023
@guanbinrui guanbinrui merged commit e798b43 into release/2.23.0 Sep 22, 2023
2 checks passed
@guanbinrui guanbinrui deleted the fix/bugfix-for-cloud-backup branch September 22, 2023 08:22
Jack-Works
Jack-Works reviewed Sep 22, 2023
View reviewed changes
packages/mask/dashboard/components/Restore/RestoreFromCloud/ConfirmBackupInfo.tsx
@@ -64,6 +64,7 @@ export const ConfirmBackupInfo = memo(function ConfirmBackupInfo() {
</PrimaryButton>,
)
}, [handleNext, t, loading])
console.log(backupFileInfo)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not remove before merge?

guanbinrui added a commit that referenced this pull request Sep 22, 2023
@nuanyang233 @guanbinrui
fix: bugfix for cloud backup (#10827)
830970f 
* fix: bugfix for cloud backup

* refactor: remove commented code

* fix: prettier

---------

Co-authored-by: guanbinrui <[email protected]>
Co-authored-by: guanbinrui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works left review comments

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nuanyang233 @Jack-Works @guanbinrui