Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfix for mf-4948 timeline calendar #10804

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

beyond009
Copy link
Contributor

@beyond009 beyond009 commented Sep 20, 2023

Description

Closes https://mask.atlassian.net/browse/MF-5284
Closes https://mask.atlassian.net/browse/MF-5296

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@beyond009 beyond009 added this to the 2.23.0 milestone Sep 20, 2023
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 05:14 Inactive
@beyond009 beyond009 changed the base branch from develop to release/2.23.0 September 20, 2023 06:10
@beyond009 beyond009 changed the base branch from release/2.23.0 to develop September 20, 2023 06:10
@github-actions github-actions bot temporarily deployed to pull request September 20, 2023 06:14 Inactive
guanbinrui
guanbinrui previously approved these changes Sep 20, 2023
@guanbinrui guanbinrui marked this pull request as ready for review September 20, 2023 07:26
@guanbinrui guanbinrui changed the base branch from develop to release/2.23.0 September 20, 2023 07:27
@guanbinrui guanbinrui changed the base branch from release/2.23.0 to develop September 20, 2023 07:29
@guanbinrui guanbinrui dismissed their stale review September 20, 2023 07:29

The base branch was changed.

@guanbinrui guanbinrui changed the base branch from develop to release/2.23.0 September 20, 2023 07:30
@guanbinrui guanbinrui merged commit 861b35c into release/2.23.0 Sep 20, 2023
12 checks passed
@guanbinrui guanbinrui deleted the fix/mf-4948-calendar branch September 20, 2023 07:31
guanbinrui pushed a commit that referenced this pull request Sep 22, 2023
* fix: click away close

* fix: mf-5284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants