Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot focus input when draft new tweet #837

Closed
guanbinrui opened this issue Mar 3, 2020 · 9 comments
Closed

[Bug] Cannot focus input when draft new tweet #837

guanbinrui opened this issue Mar 3, 2020 · 9 comments

Comments

@guanbinrui
Copy link
Member

guanbinrui commented Mar 3, 2020

Bug Report

Environment

System

  • OS: MacOS Mojave
  • OS Version: 10.14.6

Browser

  • Browser: Chrome
  • Browser Version: Version 79.0.3945.130 (Official Build) (64-bit)

Maskbook

  • Maskbook Version: 1.10.9
  • Installation: Self-Complied
  • Build Commit: 6b17838

Bug Info

Cannot focus input base again after switching the frontest window when draft secret post.

@SunriseFox
Copy link
Contributor

Is this fixed...? @guanbinrui

@guanbinrui
Copy link
Member Author

Is this fixed...? @guanbinrui

NO. Tested in 1.10.9

@SunriseFox
Copy link
Contributor

So what's wrong with #813 ...

@guanbinrui
Copy link
Member Author

So what's wrong with #813 ...

This bug existed before #813.

@Tedko
Copy link
Member

Tedko commented Mar 28, 2020

any plan to fix this one?

@Jack-Works
Copy link
Member

Cannot reproduce this problem on twitter on 5c13a2f

@guanbinrui
Copy link
Member Author

Cannot reproduce this problem on twitter on 5c13a2f

It happens when the SNS native modal coexists with the Maskbook post view.

@Tedko
Copy link
Member

Tedko commented Mar 31, 2020 via email

@guanbinrui
Copy link
Member Author

Can @binrui reproduce?

On Sat, Mar 28, 2020 at 17:01 Jack Works @.***> wrote: Cannot reproduce this problem on twitter on 5c13a2f <5c13a2f> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#837 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTAVTLLNFV56KUBESOXNNLRJW4FHANCNFSM4LAGM6QQ .

Not for the master, because of that is broken. This bug can be reproduced in v1.10.11 with following steps:

  1. Connect persona with Twitter.
  2. Open the news feed page on Twitter.
  3. Click the Tweet button to open the native compose view.
  4. Click the Compose encrypted post button to open the Maskbook compose view.
  5. Switch the frontest chrome to another one and back to chrome again.
  6. REPRODUCED: The Maskbook compose view cannot re-focus again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants