Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown field: notification and textual suggestion #46

Closed
baknu opened this issue Mar 13, 2023 · 1 comment
Closed

Unknown field: notification and textual suggestion #46

baknu opened this issue Mar 13, 2023 · 1 comment
Assignees
@DigitalTrustCenter

Comments

@baknu
Copy link
Collaborator

baknu commented Mar 13, 2023 •
edited
Loading

  1. The README states that "unknown field" triggers a notification. This seems in conformance with RFC 9116. However, the code triggers a recommendation.

  2. In the README:
    "should be ignored" --> "must be ignored"
@baknu baknu mentioned this issue Mar 15, 2023
Open
@SanderKools-Ordina SanderKools-Ordina mentioned this issue Apr 13, 2023
Merged
@DigitalTrustCenter
Copy link
Owner

#46: Unknown field: notification and textual suggestion

It's true that there was no notification support but that it was mentioned in the ReadMe. The notification messages have been added and the text for the unknown_field notification is changed as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DigitalTrustCenter DigitalTrustCenter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baknu @DigitalTrustCenter