eth_newBlockFilter

docs/methodsStatus.md

@@ -656,21 +656,21 @@ Tests:
 
 **Why (if not finished) :** Dynamic network. Tests needs improvement.
 
-## eth_newFilter
+## eth_newBlockFilter
 
 **Status :**
 
 RPC-convert:
 
-- [ ] Finished
-- [x] Not Finished
+- [x] Finished
+- [ ] Not Finished
 
 Tests:
 
-- [ ] Finished
+- [x] Finished
 - [ ] Not Finished
 
-**Why (if not finished) :**
+**Why (if not finished) :** Not supported in Starknet. Returning error with message 'the method eth_newBlockFilter does not exist/is not available'
 
 ## eth_newPendingTransactionFilter
 

src/rpc/calls.ts

@@ -37,6 +37,7 @@ import { getUncleByBlockNumberAndIndexHandler } from './calls/getUncleByBlockNum
 import { getUncleCountByBlockNumberHandler } from './calls/getUncleCountByBlockNumber'
 import { getUncleCountByBlockHashHandler } from './calls/getUncleCountByBlockHash'
 import { unsubscribeHandler } from './calls/unsubscribe'
+import { newBlockFilterHandler } from './calls/newBlockFilter'
 
 const router: Router = Router()
 
@@ -216,6 +217,11 @@ Methods.set('eth_unsubscribe', {
   handler: unsubscribeHandler,
 })
 
+Methods.set('eth_newBlockFilter', {
+  method: 'eth_newBlockFilter',
+  handler: newBlockFilterHandler,
+})
+
 router.post('/', async function (req: ParsedRequest, res: Response) {
   const request = req.rpcRequest
   if (request?.method) {

src/rpc/calls/newBlockFilter.ts

@@ -0,0 +1,14 @@
+import { RPCError, RPCRequest, RPCResponse } from '../../types/types'
+
+export async function newBlockFilterHandler(
+  request: RPCRequest,
+): Promise<RPCResponse | RPCError> {
+  return {
+    jsonrpc: request.jsonrpc,
+    id: request.id,
+    error: {
+      code: -32000,
+      message: 'the method eth_newBlockFilter does not exist/is not available', // Infura's answer
+    },
+  }
+}

tests/rpc/calls/newBlockFilter.test.ts

@@ -0,0 +1,19 @@
+import { newBlockFilterHandler } from '../../../src/rpc/calls/newBlockFilter'
+import { RPCError, RPCResponse } from '../../../src/types/types'
+
+describe('Test newBlockFilterHandler', () => {
+  it('Returns not available', async () => {
+    const request = {
+      jsonrpc: '2.0',
+      method: 'eth_newBlockFilter',
+      params: [],
+      id: 1,
+    }
+    const result: RPCResponse | RPCError = <RPCResponse>(
+      await newBlockFilterHandler(request)
+    )
+    expect(result.error?.message).toBe(
+      'the method eth_newBlockFilter does not exist/is not available',
+    )
+  })
+})