Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy odocrypt fork code #86

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Remove legacy odocrypt fork code #86

merged 1 commit into from
Feb 10, 2022

Conversation

barrystyle
Copy link

All digibyte clients are now at a sufficient PROTOCOL_VERSION, where they won't attempt to communicate with older clients.

remove unnecessary hardfork code, as version MIN_PEER_PROTO_VERSION
22f025d 
is sufficient to prevent communications with older clients
@barrystyle barrystyle changed the title remove legacy odocrypt fork code Remove legacy odocrypt fork code Jan 23, 2022
@JaredTate JaredTate self-requested a review January 28, 2022 14:02
JaredTate
JaredTate approved these changes Jan 28, 2022
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Looks straightforward. Would be great to note this PR as a guide for whenever our next upgrade/ HF is so we have a blueprint.

gto90
gto90 approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

digicontributer
digicontributer approved these changes Feb 10, 2022
View reviewed changes
Copy link

@digicontributer digicontributer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 22f025d. Looks good, Cheers.

@gto90 gto90 merged commit c03f641 into DigiByte-Core:feature/8.22.0 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gto90 gto90 gto90 approved these changes

@digicontributer digicontributer digicontributer approved these changes

@JaredTate JaredTate JaredTate approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

Assignees

@SmartArray SmartArray

@digicontributer digicontributer

@gto90 gto90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barrystyle @JaredTate @digicontributer @gto90 @SmartArray