forked from digibyte/digibyte
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Consolidates and improves the ci workflow #256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit consolidates the former Actions into a new GitHub Actions workflow that builds and tests DigiByte Core on Ubuntu with full Qt support and test coverage enabled. The workflow: - Runs on Ubuntu latest - Installs required build dependencies - Sets up Python packages needed for testing - Configures Qt5 development tools This helps ensure code quality by running comprehensive tests on pull requests develop/master branches.
…README formatting
gto90
requested review from
digicontributer,
JaredTate,
SmartArray and
ycagel
December 17, 2024 15:54
JaredTate
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK. Looks good. Thanks for doing this! Will be great to get automated tests on all PRs again.
ycagel
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cACK. Great job @gto90!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request consolidates CI workflows and improves development environment configuration by optimizing GitHub Actions performance and adding standardized VS Code settings.
Changes Made
CI Improvements:
Development Environment:
The CI improvements significantly reduce build times by caching dependencies across workflow runs, while the VS Code settings standardize the development environment for all contributors.
Additional Information
The CI optimization reduces redundant builds and downloads, making our continuous integration process more efficient. The VS Code configuration ensures consistent coding environment across different development setups.